Switch to defaultValue and add a test for typing (jupyterlab#14085)

skyetim · Feb 27, 2023 · 115369f · 115369f
1 parent f7718db
commit 115369f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/galata/test/jupyterlab/notebook-search.test.ts b/galata/test/jupyterlab/notebook-search.test.ts
@@ -35,6 +35,18 @@ test.describe('Notebook Search', () => {
     expect(await nbPanel.screenshot()).toMatchSnapshot('search.png');
   });
 
+  test('Typing in search box', async ({ page }) => {
+    // Check against React being too eager with controling state of input box
+    await page.keyboard.press('Control+f');
+
+    await page.fill('[placeholder="Find"]', '14');
+    await page.press('[placeholder="Find"]', 'ArrowLeft');
+    await page.type('[placeholder="Find"]', '2');
+    await page.type('[placeholder="Find"]', '3');
+
+    await expect(page.locator('[placeholder="Find"]')).toHaveValue('1234');
+  });
+
   test('RegExp parsing failure', async ({ page }) => {
     await page.keyboard.press('Control+f');
 

diff --git a/packages/documentsearch/src/searchview.tsx b/packages/documentsearch/src/searchview.tsx
@@ -80,9 +80,8 @@ function SearchInput(props: ISearchInputProps): JSX.Element {
       tabIndex={0}
       ref={props.inputRef}
       title={props.title}
-    >
-      {props.value}
-    </textarea>
+      defaultValue={props.value}
+    ></textarea>
   );
 }