Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update --env-file to sky doc #4345

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Update --env-file to sky doc #4345

merged 8 commits into from
Nov 14, 2024

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Nov 13, 2024 •
edited
Loading

  • Add the parameter --env-file to environment-variables.rst to complete the doc and example.
  • Trailing-whitespace hook automatically fixes some white spaces.

Tested here

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@zpoint zpoint changed the title update doc update --env-file to sky doc Nov 13, 2024
@zpoint zpoint changed the title update --env-file to sky doc Update --env-file to sky doc Nov 13, 2024
concretevitamin
concretevitamin approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zpoint, LGTM.

docs/source/running-jobs/environment-variables.rst Outdated Show resolved Hide resolved
docs/source/running-jobs/environment-variables.rst Outdated Show resolved Hide resolved
docs/source/running-jobs/environment-variables.rst Show resolved Hide resolved
@concretevitamin concretevitamin added this pull request to the merge queue Nov 14, 2024
Merged via the queue into skypilot-org:master with commit 1c04aef Nov 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zpoint @concretevitamin