Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue storage deletion when some fail #4454
base: master
Are you sure you want to change the base?
Continue storage deletion when some fail #4454
Changes from 2 commits
b9e81d1
9f87404
4fd28bb
36ca3a3
8b7b075
fa6037f
1d67da7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding this seems change the return value type from
Value
toUnion[Value, Exception]
, which looks a little bit strange to me. Why do we need this anyway? aren't we already add the try-except in the func?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I thought about not adding a function to catch and log these exceptions, but instead handle all exceptions in
run_in_parallel
. Anyway, it made sense to have this function have an argument likecontinue_on_error
.But then I realized it violated the abstraction concept and would make it harder to print custom logs. So I ended up wrapping the function and logging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not removing this reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean why remove the reference? I think it's trivial now, and the reference doesn't add much value to the code.