Skip to content

Commit

Permalink
feat: replace hasura actions base URL with env variable (forbole#379)
Browse files Browse the repository at this point in the history
## Description

Closes: forbole#373 

Currently hasura actions' handler URL is hard-coded as `http://localhost:3000/[actions]`.
This PR replaces `http://localhost:3000` with `{{ACTION_BASE_URL}}` in the metadata file `actions.yaml` so hasura can read the custom handler URL from environment variable while applying hasura metadata. 

Note: 
Might need to add `-e ACTION_BASE_URL="http://localhost:3000"` as example in the setup instructions. 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
  • Loading branch information
huichiaotsou authored Apr 7, 2022
1 parent 5f4147d commit 71648aa
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions hasura/metadata/actions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ actions:
- name: action_account_balance
definition:
kind: synchronous
handler: http://localhost:3000/account_balance
handler: "{{ACTION_BASE_URL}}/account_balance"
output_type: ActionBalance
arguments:
- name: address
Expand All @@ -23,7 +23,7 @@ actions:
- name: action_delegation_reward
definition:
kind: synchronous
handler: http://localhost:3000/delegation_reward
handler: "{{ACTION_BASE_URL}}/delegation_reward"
output_type: "[ActionDelegationReward]"
arguments:
- name: address
Expand All @@ -40,7 +40,7 @@ actions:
- name: action_delegator_withdraw_address
definition:
kind: synchronous
handler: http://localhost:3000/delegator_withdraw_address
handler: "{{ACTION_BASE_URL}}/delegator_withdraw_address"
output_type: ActionAddress
arguments:
- name: address
Expand All @@ -55,7 +55,7 @@ actions:
- name: action_delegation
definition:
kind: synchronous
handler: http://localhost:3000/delegation
handler: "{{ACTION_BASE_URL}}/delegation"
output_type: ActionDelegationResponse
arguments:
- name: address
Expand All @@ -78,7 +78,7 @@ actions:
- name: action_delegation_total
definition:
kind: synchronous
handler: http://localhost:3000/delegation_total
handler: "{{ACTION_BASE_URL}}/delegation_total"
output_type: ActionBalance
arguments:
- name: address
Expand All @@ -95,7 +95,7 @@ actions:
- name: action_redelegation
definition:
kind: synchronous
handler: http://localhost:3000/redelegation
handler: "{{ACTION_BASE_URL}}/redelegation"
output_type: ActionRedelegationResponse
arguments:
- name: address
Expand All @@ -118,7 +118,7 @@ actions:
- name: action_unbonding_delegation
definition:
kind: synchronous
handler: http://localhost:3000/unbonding_delegation
handler: "{{ACTION_BASE_URL}}/unbonding_delegation"
output_type: ActionUnbondingDelegationResponse
arguments:
- name: address
Expand All @@ -141,7 +141,7 @@ actions:
- name: action_unbonding_delegation_total
definition:
kind: synchronous
handler: http://localhost:3000/unbonding_delegation_total
handler: "{{ACTION_BASE_URL}}/unbonding_delegation_total"
output_type: ActionBalance
arguments:
- name: address
Expand All @@ -159,7 +159,7 @@ actions:
- name: action_validator_commission_amount
definition:
kind: synchronous
handler: http://localhost:3000/validator_commission_amount
handler: "{{ACTION_BASE_URL}}/validator_commission_amount"
output_type: "[ActionValidatorCommissionAmount]"
arguments:
- name: address
Expand All @@ -174,7 +174,7 @@ actions:
- name: action_validator_delegations
definition:
kind: synchronous
handler: http://localhost:3000/validator_delegations
handler: "{{ACTION_BASE_URL}}/validator_delegations"
output_type: ActionDelegationResponse
arguments:
- name: address
Expand All @@ -195,7 +195,7 @@ actions:
- name: action_validator_redelegations_from
definition:
kind: synchronous
handler: http://localhost:3000/validator_redelegations_from
handler: "{{ACTION_BASE_URL}}/validator_redelegations_from"
output_type: ActionRedelegationResponse
arguments:
- name: address
Expand All @@ -218,7 +218,7 @@ actions:
- name: action_validator_unbonding_delegations
definition:
kind: synchronous
handler: http://localhost:3000/validator_unbonding_delegations
handler: "{{ACTION_BASE_URL}}/validator_unbonding_delegations"
output_type: ActionUnbondingDelegationResponse
arguments:
- name: address
Expand Down

0 comments on commit 71648aa

Please sign in to comment.