Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all format-like macros for Clippy #7689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Feb 21, 2025

Allows Clippy to lint format-like usage of non-standard macros

See https://doc.rust-lang.org/nightly/clippy/attribs.html#clippyformat_args

@nyurik
Copy link
Contributor Author

nyurik commented Feb 21, 2025

It seems this is due to rust-lang/rust#98291 - it might mean the actual macros are being declared incorrectly by Slint, but there is no warning about it because of a bug in the compiler? Or that the compiler simply doesn't have a good error message for this. Or ... TBD.

@ogoffart
Copy link
Member

Thanks for the PR, looks nice.
Too bad this causes compilation error. My intuition tells me the compiler think that #[clippy::...] is a macro.
Perhaps it could be worked around by adding a #[cfg_attr(clippy, ...)] or something like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants