fsnotify: replace igrab() with ihold() on attach connector

We must have a reference on inode, so ihold is cheaper. Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Matthew Bobrowski <[email protected]> Signed-off-by: Amir Goldstein <[email protected]> Signed-off-by: Jan Kara <[email protected]>
sm00th · Aug 11, 2021 · 09ddbe6 · 09ddbe6
1 parent af579be
commit 09ddbe6
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/fs/notify/mark.c b/fs/notify/mark.c
@@ -493,8 +493,11 @@ static int fsnotify_attach_connector_to_object(fsnotify_connp_t *connp,
 		conn->fsid.val[0] = conn->fsid.val[1] = 0;
 		conn->flags = 0;
 	}
-	if (conn->type == FSNOTIFY_OBJ_TYPE_INODE)
-		inode = igrab(fsnotify_conn_inode(conn));
+	if (conn->type == FSNOTIFY_OBJ_TYPE_INODE) {
+		inode = fsnotify_conn_inode(conn);
+		ihold(inode);
+	}
+
 	/*
 	 * cmpxchg() provides the barrier so that readers of *connp can see
 	 * only initialized structure