Skip to content

Commit

Permalink
selftests: netdevsim: Always initialize 'RET' variable
Browse files Browse the repository at this point in the history
The variable is used by log_test() to check if the test case completely
successfully or not. In case it is not initialized at the start of a
test case, it is possible for the test case to fail despite not
encountering any errors.

Example:

```
...
TEST: Trap group statistics                                         [ OK ]
TEST: Trap policer                                                  [FAIL]
	Policer drop counter was not incremented
TEST: Trap policer binding                                          [FAIL]
	Policer drop counter was not incremented
```

Failure of trap_policer_test() caused trap_policer_bind_test() to fail
as well.

Fix by adding missing initialization of the variable.

Fixes: 5fbff58 ("selftests: netdevsim: Add test cases for devlink-trap policers")
Signed-off-by: Ido Schimmel <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
idosch authored and davem330 committed May 22, 2020
1 parent be43224 commit 4d59e59
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,8 @@ trap_policer_test()
local packets_t0
local packets_t1

RET=0

if [ $(devlink_trap_policers_num_get) -eq 0 ]; then
check_err 1 "Failed to dump policers"
fi
Expand Down Expand Up @@ -328,6 +330,8 @@ trap_group_check_policer()

trap_policer_bind_test()
{
RET=0

devlink trap group set $DEVLINK_DEV group l2_drops policer 1
check_err $? "Failed to bind a valid policer"
if [ $(devlink_trap_group_policer_get "l2_drops") -ne 1 ]; then
Expand Down

0 comments on commit 4d59e59

Please sign in to comment.