Skip to content

Commit

Permalink
clk: berlin: drop direct of_iomap of nodes reg property
Browse files Browse the repository at this point in the history
The Berlin clock driver was sharing a DT node with the pin controller
and the reset driver. All these devices are now sub-nodes of the chip
controller. This patch rework the Berlin clock driver to allow moving
the Berlin clock DT bindings into their own sub-node of the chip
controller node.

Signed-off-by: Antoine Tenart <[email protected]>
Acked-by: Stephen Boyd <[email protected]>
Signed-off-by: Sebastian Hesselbarth <[email protected]>
  • Loading branch information
atenart authored and shesselba committed May 18, 2015
1 parent a457b86 commit fd26031
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
9 changes: 1 addition & 8 deletions drivers/clk/berlin/bg2.c
Original file line number Diff line number Diff line change
Expand Up @@ -508,10 +508,7 @@ static void __init berlin2_clock_setup(struct device_node *np)
u8 avpll_flags = 0;
int n;

if (of_device_is_compatible(parent_np, "syscon"))
np = parent_np;

gbase = of_iomap(np, 0);
gbase = of_iomap(parent_np, 0);
if (!gbase)
return;

Expand Down Expand Up @@ -689,9 +686,5 @@ static void __init berlin2_clock_setup(struct device_node *np)
bg2_fail:
iounmap(gbase);
}
CLK_OF_DECLARE(berlin2_clock, "marvell,berlin2-chip-ctrl",
berlin2_clock_setup);
CLK_OF_DECLARE(berlin2cd_clock, "marvell,berlin2cd-chip-ctrl",
berlin2_clock_setup);
CLK_OF_DECLARE(berlin2_clk, "marvell,berlin2-clk",
berlin2_clock_setup);
9 changes: 2 additions & 7 deletions drivers/clk/berlin/bg2q.c
Original file line number Diff line number Diff line change
Expand Up @@ -295,17 +295,14 @@ static void __init berlin2q_clock_setup(struct device_node *np)
struct clk *clk;
int n;

if (of_device_is_compatible(parent_np, "syscon"))
np = parent_np;

gbase = of_iomap(np, 0);
gbase = of_iomap(parent_np, 0);
if (!gbase) {
pr_err("%s: Unable to map global base\n", np->full_name);
return;
}

/* BG2Q CPU PLL is not part of global registers */
cpupll_base = of_iomap(np, 1);
cpupll_base = of_iomap(parent_np, 1);
if (!cpupll_base) {
pr_err("%s: Unable to map cpupll base\n", np->full_name);
iounmap(gbase);
Expand Down Expand Up @@ -388,7 +385,5 @@ static void __init berlin2q_clock_setup(struct device_node *np)
iounmap(cpupll_base);
iounmap(gbase);
}
CLK_OF_DECLARE(berlin2q_clock, "marvell,berlin2q-chip-ctrl",
berlin2q_clock_setup);
CLK_OF_DECLARE(berlin2q_clk, "marvell,berlin2q-clk",
berlin2q_clock_setup);

0 comments on commit fd26031

Please sign in to comment.