Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version of pdfjs-dist package #25

Conversation

islambek01
Copy link
Contributor

No description provided.

@andyhot
Copy link
Contributor

andyhot commented Mar 27, 2020

Does this resolve #24 ?

@andyhot
Copy link
Contributor

andyhot commented Mar 27, 2020

This would also resolve #21 - and i think it warrants a version bump to 1.0.0

@marceloandrader Are you guys still using this? Do you want to give this a try with the latest pdfjs-dist version?

@marceloandrader
Copy link
Member

hey @andyhot yes we still use it, I dont' have time today but I can check next week. We use some APIs for searching so I hope they are compatible.

@andyhot
Copy link
Contributor

andyhot commented Mar 27, 2020

thx @marceloandrader - well, if we bump this to 1.0.0 you can still use the version you use and later on upgrade at will. @islambek01 won't that also work for you?

@islambek01
Copy link
Contributor Author

Does this resolve #24 ?

Yes. @andyhot

@islambek01
Copy link
Contributor Author

islambek01 commented Mar 29, 2020

thx @marceloandrader - well, if we bump this to 1.0.0 you can still use the version you use and later on upgrade at will. @islambek01 won't that also work for you?

@andyhot Thank's a lot for making this package which solves our real problem))
so, when the latest 1.0.0 version of ember-pdf-js will be ready in npmjs.com?
We are using ember-pdf-js, there is an error #24 in our production. I have to solve it as soon as possible for our production app.

@marceloandrader
Copy link
Member

hey @islambek01 just checked out your branch and tried to run the tests and the code is not compatible with PDFJs 2.3 you will have to make the modifications to make the tests pass. For example that version doesn't have a PDFJS global, now is pdfjsViewer and other couple globals, I tried changing that but looks like the API also changed. To merge this at least the tests must pass.

@islambek01
Copy link
Contributor Author

hey @islambek01 just checked out your branch and tried to run the tests and the code is not compatible with PDFJs 2.3 you will have to make the modifications to make the tests pass. For example that version doesn't have a PDFJS global, now is pdfjsViewer and other couple globals, I tried changing that but looks like the API also changed. To merge this at least the tests must pass.

@andyhot, I updated pdfjs-dist package to version 1.9.486 and it's compatible all tests passed. And issue #24 was solved by pdfjs-dist above the version - 1.8.170.

@marceloandrader marceloandrader merged commit eb1c8db into smith-carson:dev Apr 1, 2020
This was referenced Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants