-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated version of pdfjs-dist package #25
updated version of pdfjs-dist package #25
Conversation
Does this resolve #24 ? |
This would also resolve #21 - and i think it warrants a version bump to 1.0.0 @marceloandrader Are you guys still using this? Do you want to give this a try with the latest |
hey @andyhot yes we still use it, I dont' have time today but I can check next week. We use some APIs for searching so I hope they are compatible. |
thx @marceloandrader - well, if we bump this to 1.0.0 you can still use the version you use and later on upgrade at will. @islambek01 won't that also work for you? |
@andyhot Thank's a lot for making this package which solves our real problem)) |
hey @islambek01 just checked out your branch and tried to run the tests and the code is not compatible with PDFJs 2.3 you will have to make the modifications to make the tests pass. For example that version doesn't have a PDFJS global, now is pdfjsViewer and other couple globals, I tried changing that but looks like the API also changed. To merge this at least the tests must pass. |
@andyhot, I updated pdfjs-dist package to version 1.9.486 and it's compatible all tests passed. And issue #24 was solved by pdfjs-dist above the version - 1.8.170. |
No description provided.