Use exec form instead of shell form for CMD #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 45.89% 45.89%
=======================================
Files 7 7
Lines 268 268
=======================================
Hits 123 123
Misses 134 134
Partials 11 11Continue to review full report at Codecov.
|
This will make our process run as pid1 in the container. This removes the need for having a shell in the final container and is the preferred way to use CMD according to the official docker documentation.
hanhui870
pushed a commit
to hanhui870/docker-registry-manager
that referenced
this pull request
Jan 28, 2018
Use exec form instead of shell form for CMD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make our process run as pid1 in the container. This removes
the need for having a shell in the final container and is the preferred
way to use CMD according to the official docker documentation.