Fixed two CF memory leaks. (Fixes issue #5)

snej · Apr 28, 2009 · 335b9d1 · 335b9d1
1 parent 0eb23c1
commit 335b9d1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/BLIP/BLIPTest.m b/BLIP/BLIPTest.m
@@ -52,6 +52,7 @@ static SecIdentityRef ChooseIdentity( NSString *prompt ) {
     SecIdentityRef identity;
     while (SecIdentitySearchCopyNext(search, &identity) == noErr)
         [identities addObject: (id)identity];
+    CFRelease(search);
     Log(@"Found %u identities -- prompting '%@'", identities.count, prompt);
     if (identities.count > 0) {
         SFChooseIdentityPanel *panel = [SFChooseIdentityPanel sharedChooseIdentityPanel];

diff --git a/TCP/TCPConnection.m b/TCP/TCPConnection.m
@@ -111,14 +111,16 @@ - (id) initIncomingFromSocket: (CFSocketNativeHandle)socket
     CFWriteStreamRef writeStream = NULL;
     CFStreamCreatePairWithSocket(kCFAllocatorDefault, socket, &readStream, &writeStream);
     self = [self _initWithAddress: [IPAddress addressOfSocket: socket] 
-                      inputStream: (NSInputStream*)readStream
-                     outputStream: (NSOutputStream*)writeStream];
+                      inputStream: (NSInputStream*)CFMakeCollectable(readStream)
+                     outputStream: (NSOutputStream*)CFMakeCollectable(writeStream)];
     if( self ) {
         _isIncoming = YES;
         _server = [listener retain];
         CFReadStreamSetProperty(readStream, kCFStreamPropertyShouldCloseNativeSocket, kCFBooleanTrue);
         CFWriteStreamSetProperty(writeStream, kCFStreamPropertyShouldCloseNativeSocket, kCFBooleanTrue);
     }
+    if(readStream) CFRelease(readStream);
+    if(writeStream) CFRelease(writeStream);
     return self;
 }