Enable more eslint rules

snewcomer · Feb 1, 2022 · d11de20 · d11de20
1 parent a9b976c
commit d11de20
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -49,11 +49,16 @@ module.exports = {
         // TODO: stop disabling these rules
         'prefer-const': 'off',
         'no-prototype-builtins': 'off',
-        '@typescript-eslint/ban-types': 'off',
-        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/ban-types': [
+          'error',
+          {
+            extendDefaults: true,
+            types: {
+              '{}': false,
+            },
+          },
+        ],
         '@typescript-eslint/no-non-null-assertion': 'off',
-        '@typescript-eslint/explicit-module-boundary-types': 'off',
-        '@typescript-eslint/no-this-alias': 'off',
       },
     },
 

diff --git a/lib/router/route-info.ts b/lib/router/route-info.ts
@@ -22,7 +22,7 @@ export interface Route<T extends IModel = {}> {
   routeName: string;
   _internalName: string;
   context: T | undefined;
-  events?: Dict<Function>;
+  events?: Dict<(...args: unknown[]) => unknown>;
   model?(params: Dict<unknown>, transition: Transition): PromiseLike<T> | undefined | T;
   deserialize?(params: Dict<unknown>, transition: Transition): T | PromiseLike<T> | undefined;
   serialize?(model: T | undefined, params: string[]): Dict<unknown> | undefined;

diff --git a/tests/test_helpers.ts b/tests/test_helpers.ts
@@ -11,7 +11,7 @@ import { isTransitionAborted } from 'router/transition-aborted-error';
 QUnit.config.testTimeout = 1000;
 
 let bb = new Backburner(['promises']);
-function customAsync(callback: Function, promise: Promise<unknown>) {
+function customAsync(callback: (...args: unknown[]) => unknown, promise: Promise<unknown>) {
   bb.defer('promises', promise, callback, promise);
 }