add Applicative and Monad instances for Label

[subttle]

No description provided.

[snowleopard]

Thanks @subttle! While the instances look reasonable, it's not obvious to me that Applicative and Monad laws hold. Could you give some intuition about why you chose this particular implementation, and why it satisfies the expected laws?

[snowleopard]

@subttle Strange: I received an email notification with your comment about using QuickCheck, but it doesn't seem to be here. Have you deleted it, or is it a GitHub glitch?

Regarding using QuickCheck: this requires an Eq Label instance, but we don't have one. Which one did you use?

[subttle]

Hi! Thank you for considering this PR.

The notification was because I went to shift-enter for a newline but instead entered the comment, doh!

While not a substitute for a proof (I will try to do one which considers the appropriate graph laws), I had done some basic checks with QuickCheck and checkers.

instance (Arbitrary a) => Arbitrary (Label a) where
    -- This particular instance may be large or even not terminate
    arbitrary = oneof [ pure Zero
                      , pure One
                      , fmap Symbol arbitrary
                      , fmap Star arbitrary
                      , liftA2 (:+:) arbitrary arbitrary
                      , liftA2 (:*:) arbitrary arbitrary
                      ]

And also adding a Generic to the derived list for Label, then checking with checkers.

λ> quickBatch $ functor (undefined :: Label (Int, String, Char))

functor:
  identity: +++ OK, passed 500 tests.
  compose:  +++ OK, passed 500 tests.
λ> quickBatch $ applicative (undefined :: Label (Int, String, Char))

applicative:
  identity:     +++ OK, passed 500 tests.
  composition:  +++ OK, passed 500 tests.
  homomorphism: +++ OK, passed 500 tests.
  interchange:  +++ OK, passed 500 tests.
  functor:      +++ OK, passed 500 tests.
λ> quickBatch $ monad (undefined :: Label (Int, String, Char))

monad laws:
  left  identity: +++ OK, passed 500 tests.
  right identity: +++ OK, passed 500 tests.
  associativity:  +++ OK, passed 500 tests.
λ> 

Although, I had only used an instance of EqProp which uses the default eq implementation (I think this is structural equality by default which I'm sure you do not use) so I should try again after updating that accordingly. As far as intuition goes, I think the implementation of pure is the natural one considering the implementation of Functor, and the rest of the implementation I drew inspiration from a tree monad implementation. I will comment again soon when I can try out what I mentioned.

[snowleopard]

Thanks @subttle! One simple thing to do to at least resolve the question about the validity of the Applicative instance is to use (<*>) = ap as the implementation. This is required by Applicative-Monad laws anyway, plus makes the implementation simpler.