Added Requested Feature: Writer Audio lerp toggle (take 3) #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue seemed simple to tackle and the feature would be nice to add depending on what audio you use. The dopplering effect is minor with the built-in sound clips, but amplified with things like typewriters. * Added a Lerp Writer Audio bool. * When enabled (default), the WriterAudio uses the default behaviour of using MoveTowards for volume. * When disabled, the WriterAudio sets the audio volume to the target volume while writing, removing the lerp effect. This setting is enabled by default on the say dialogue prefab Fungus spawns by default and therefore cannot be set at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a toggle to Writer Audio so the Writer does not lerp audio while writing. This results in the volume being consistent while writing.
Default and prefab Say Dialogs have this enabled so they will lerp audio by default. The user must change the prefab settings or create a custom Say Dialog to make use of this change.
What is the current behavior?
Issue Number: #929
When using a sound such as typewriters or other effects, the lerping audio can cause the sound to change volume rapidly and not sound consistent. This can be replicated by doing the following:
The sound modulates heavily as it stops and stops. With the other voices, it's not heard, but with one consistent sound effect, the effect is noticeable and causes peaks in the audio levels.
What is the new behavior?
Important Notes
My change require modifcations or additions to documentation
My change modifies the runtime execution/behaviour of existing Fungus Features. e.g., Say, Menus, Portraits, etc.
Other information
This is a rehash of #934 , but without the stupid mistake that has messed up all of my other PR's. I swear, I know how to use Git.