Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Punch/Wobble effect to speaking character #887

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

breadnone
Copy link
Contributor

@breadnone breadnone commented Sep 29, 2020

Add Punch effect to the speaking character, this can be used together with Dim as well.

The idea came from our tester, as he can't tell who's actually speaking if "Dim" wasn't being used (even though the name of the character was displayed)

Description

New added feature as shown in the gif below:
uImpjeIwEC

Add new checkbox in Stage setting
Edit: Flash changed to Punch to be consistent with Fungus
flashportraitFungame

What is the current behavior?

This feature is not explicitly available in Fungus

What is the new behavior?

Adding new Punch tween setting to be part of Fungus's Stage system including ControlStage

Important Notes

  • Add new public bool to PortraitUtils
    If this breaks Fungus code standard or if it's not allowed, pls let me know,
  • The name "Flash" displayed in Stage setting because the word "Punch" would confuse users. Obviously, this can be changed.

Other information

It should not break compatibility.

Add Punch to the speaking character, this can be used together with Dim as well
User might confused with the word "Flash" so "Punch" used instead. Either way, those two seem confusing no matter what
@breadnone breadnone changed the base branch from master to develop September 30, 2020 09:13
Set it back to it's default previous position, just in case
@stevehalliwell stevehalliwell added this to the 3.15 milestone Oct 24, 2020
@breadnone
Copy link
Contributor Author

I really think there should be combobox to choose what effects would be used rather than check boxes. Not only it would make things more tidy but also make new addition for character effects easier.

But that should be in separate pr...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants