throw error when the combo url is too long. close seajs#230

soda-x · Jun 26, 2012 · f456d77 · f456d77
1 parent cb3b951
commit f456d77
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/dist/plugin-combo.js b/dist/plugin-combo.js
@@ -199,8 +199,14 @@ define('seajs/plugin-combo', function() {
     util.forEach(paths, function(path) {
       var root = path[0] + '/'
       var parts = path[1]
-      var comboPath = root + comboSyntax[0] + parts.join(comboSyntax[1])
+
       var hash = {}
+      var comboPath = root + comboSyntax[0] + parts.join(comboSyntax[1])
+
+      // http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url
+      if (comboPath.length > 2000) {
+        throw new Error('The combo url is too long: ' + comboPath)
+      }
 
       util.forEach(parts, function(part) {
         hash[root + part] = comboPath

diff --git a/src/plugins/plugin-combo.js b/src/plugins/plugin-combo.js
@@ -199,8 +199,14 @@ define('seajs/plugin-combo', function() {
     util.forEach(paths, function(path) {
       var root = path[0] + '/'
       var parts = path[1]
-      var comboPath = root + comboSyntax[0] + parts.join(comboSyntax[1])
+
       var hash = {}
+      var comboPath = root + comboSyntax[0] + parts.join(comboSyntax[1])
+
+      // http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url
+      if (comboPath.length > 2000) {
+        throw new Error('The combo url is too long: ' + comboPath)
+      }
 
       util.forEach(parts, function(part) {
         hash[root + part] = comboPath