Bugfix/number literal format fix (palantir#4856)

* Add failing test case. * Preserve significant zeros in fix.
soffieswan043 · Sep 12, 2019 · 5cf6e65 · 5cf6e65
1 parent 98edf1a
commit 5cf6e65
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/rules/numberLiteralFormatRule.ts b/src/rules/numberLiteralFormatRule.ts
@@ -101,7 +101,7 @@ function walk(ctx: Lint.WalkContext): void {
 
         const [num, exp = ""] = text.split(/e/i);
         const [integer, float = ""] = num.split(".");
-        const matchedNumeric = /(\.)([1-9]*)(0+)/.exec(num);
+        const matchedNumeric = /(\.)(\d*?)(0+)$/.exec(num);
         const [dot = "", numbers = "", zeroes = ""] = Array.isArray(matchedNumeric)
             ? matchedNumeric.slice(1)
             : [];

diff --git a/test/rules/number-literal-format/test.ts.fix b/test/rules/number-literal-format/test.ts.fix
@@ -43,3 +43,5 @@
 
 0xDEADBEEF;
 
+0.0102;
+
diff --git a/test/rules/number-literal-format/test.ts.lint b/test/rules/number-literal-format/test.ts.lint
@@ -67,6 +67,9 @@
 0xDEAdBEEF;
 ~~~~~~~~~~ [uppercase]
 
+0.010200;
+~~~~~~~~ [trailing-0]
+
 [leading-0]: Number literal should not have a leading '0'.
 [trailing-0]: Number literal should not have a trailing '0'.
 [trailing-decimal]: Number literal should not end in '.'.