Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different OAEP modes using OpenSSL EVP interface #583

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

borancar
Copy link

@borancar borancar commented Oct 30, 2020

Using EVP interface, we can support different OAEP padding modes, such as OAEP-SHA224, OAEP-SHA256, OAEP-SHA384, OAEP-SHA512. This is my attempt at plumbing the support in - let me know if I'm doing it right. Fixes #474.

@borancar
Copy link
Author

I've tested decryption across all of them. Could someone help me test encryption?

@borancar borancar closed this Oct 30, 2020
@borancar borancar reopened this Oct 30, 2020
@borancar borancar changed the title WIP: Support different OAEP modes using OpenSSL EVP interface Support different OAEP modes using OpenSSL EVP interface Oct 30, 2020
@borancar
Copy link
Author

Implement all OAEP tests and they all pass now. The only workaround is not to use key size of 1024 for OAEP-SHA512.

@rijswijk
Copy link
Contributor

rijswijk commented Nov 4, 2020

Thanks for this contribution; once you think it is ready for review, can you create a pull request so we can review the code?

@rijswijk
Copy link
Contributor

rijswijk commented Nov 4, 2020

Had a quick look at the code, looks good at first glance. To bump the OpenSSL version, you should also update m4/acx_crypto_backend.m4.

From what I see, EVP is introduced with version 1.0.2 and we require it
for the OAEP methods.
@borancar
Copy link
Author

borancar commented Nov 4, 2020

Done, thanks!

@kant-chen
Copy link

Hello,

Just came across and I am happy that there is already a solution for supporting different hash algorithm other than SHA1 .
Could someone help to merge it if there is no issue?
This would really help the things I am currently doing.
Thanks in advance!

@jschlyter
Copy link
Contributor

Please rebase on develop and mark as ready when ready.

@jschlyter jschlyter marked this pull request as draft November 29, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OAEP mechanisms different than SHA1
5 participants