Replace CKR_ARGUMENTS_BAD by a better error code when appropriate #632
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cases where the error is due to a limitation in the implementation (e.g., digest type in OAEP), return CKM_MECHANISM_PARAMETER_INVALID instead of CKR_ARGUMENTS_BAD Where the parameter is evidently wrong (like NULL for a required parameter), CKR_ARGUMENTS_BAD is retained. Signed-off-by: Selva Nair <[email protected]>
|
PS: I'm not sure of how to treat the |
|
Please rebase on develop and mark as ready when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases where the error is due to a limitation in the
implementation (e.g., digest type in OAEP), return
CKM_MECHANISM_PARAMETER_INVALID instead of CKR_ARGUMENTS_BAD
Where the parameter is evidently wrong (like NULL for a
required parameter), CKR_ARGUMENTS_BAD is retained.
Signed-off-by: Selva Nair [email protected]