Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of response specifications #2365

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

adamw
Copy link
Member

@adamw adamw commented Dec 10, 2024

Closes #1771

Changes:

  • introduce asXyzOrFail methods which throw exceptions for non-2xx responses
  • add asJsonOrFail, asJsonOrFailEither variants to all integrations
  • quickRequest now uses asStringOrFail as the default response type
  • scaladocs & docs updates
  • move .mapRight, .orFail to ResponseAs for better discoverability (instead of extension methods), however this causes that type parameters have to be provided explicitly sometimes

cc @bishabosha @lbialy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Variant of asJson that always throws
1 participant