Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add createAsync primitive #762

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

add createAsync primitive #762

wants to merge 12 commits into from

Conversation

birkskyum
Copy link

This is the createAsync primitive from the @solidjs/router

https://github.com/solidjs/solid-router/blob/main/src/data/createAsync.ts

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5e0161e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetarnav
Copy link
Member

Although I don't mind, after solid 2.0 this will just get deprecated?

@birkskyum
Copy link
Author

birkskyum commented Feb 20, 2025 •
edited
Loading

Yes, it'll be obsoleted by a core primitive.

thetarnav
thetarnav requested changes Feb 20, 2025
View reviewed changes
packages/async/src/index.ts
Comment on lines +153 to +154
function subFetch<T>(fn: (prev: T | undefined) => Promise<T>, prev: T | undefined) {
if (isServer || !sharedConfig.context) return fn(prev);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some explanation on this one, it looks wild.

@ryansolid
Copy link
Collaborator

Hold on this until we decide this is worth the temporary disruption.

@birkskyum birkskyum closed this Feb 20, 2025
@birkskyum birkskyum reopened this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetarnav thetarnav thetarnav requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birkskyum @thetarnav @ryansolid