-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Remove SKU ACS-SN4280 #21809
Open
ram25794
wants to merge
8
commits into
sonic-net:master
Choose a base branch
from
ram25794:Remove_SKU_ACS-SN4280
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ram25794 <[email protected]>
Signed-off-by: ram25794 <[email protected]>
Signed-off-by: ram25794 <[email protected]>
Signed-off-by: ram25794 <[email protected]>
Signed-off-by: ram25794 <[email protected]>
dgsudharsan
approved these changes
Feb 20, 2025
oleksandrivantsiv
approved these changes
Feb 20, 2025
@liat-grozovik can you please help to merge? |
liat-grozovik
approved these changes
Feb 24, 2025
/azpw run Azure.sonic-buildimage |
1 similar comment
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Every ACS-.....SKU is expected to have ingress_lossy pool but SKU ACS-SN4280 does not contain it. So removing the ACS SKU to make it compliant.
Work item tracking
How I did it
Removed the symlinks in Mellanox-SN4280-O28 folder and added the required files.
How to verify it
Generated config using Mellanox-SN4280-O28 SKU and tested on the device
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)