[action] [PR:21775] [chassis-packet] Allow Fallback Route to get programmed on Downstream LC #21833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What/Why I did: Initially I made the change that Fallback Route [routes from AH on Upstream LC] not to get programmed [mark them as deny] on Downstream LC's as reasoning was that on Downstream LC's can forward them based on Default-route. However that assumption is correct for example we have topology like this: RH is connected to ASIC0 of Upstream LC AH is connected to ASIC1 of Upstream LC Downstream LC will learn route from RH [including default-route] and will only forward to ASIC0 of upstream LC . Above assumption was fine if we always have AH and RH connected to same ASIC of Upstream LC. How I verify: UT updated Manual Verification.
|
Original PR: #21775 |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why I did:
Initially I made the change that Fallback Route [routes from AH on Upstream LC] not to get programmed [mark them as deny] on Downstream LC's as reasoning was that on Downstream LC's can forward them based on Default-route. However that assumption is correct for example we have topology like this:
RH is connected to ASIC0 of Upstream LC
AH is connected to ASIC1 of Upstream LC
Downstream LC will learn route from RH [including default-route] and will only forward to ASIC0 of upstream LC . Above assumption was fine if we always have AH and RH connected to same ASIC of Upstream LC.
How I verify:
UT updated
Manual Verification.