add constructor check utility methods to SootClass #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissiety
reviewed
Mar 10, 2025
Comment on lines
+223
to
+232
| /** @return true if the method is a constructor */ | ||
| public boolean isConstructor(@Nonnull IdentifierFactory idf) { | ||
| return idf.isConstructorSignature(getSignature()); | ||
| } | ||
|
|
||
| /** @return true if the method is the default constructor */ | ||
| public boolean isDefaultConstructor(@Nonnull IdentifierFactory idf) { | ||
| return isConstructor(idf) && getParameterCount() == 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
shall we move that into the IdentifierFactory and pass a Signature?
There was a problem hiding this comment.
The IDF already contains the methods for checking singatures. I think it's more intuitive to look for these checks on the SootMethod itself. All the modifier checks are performed on the SootMethod. It seems kinda unintuitive and not obvious for unexperienced users to have to look at the IDF for this info. We might even consider to have a more concrete implementation on the JavaSootMethod that does not even need the IDF as parameter, but directly uses the Java IDF.
kadirayk
approved these changes
Mar 11, 2025
swissiety
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.