Skip to content

Commit

Permalink
doc: remove last pieces of advice to set GOROOT
Browse files Browse the repository at this point in the history
install.html still insisted that GOROOT must be set if a binary install
of Go is set up in a custom directory. However, since 1.10, this has
been unnecessary as the GOROOT will be found based on the location of
the 'go' binary being run.

Likewise, install-source.html includes an 'export GOROOT' line in a
section that only talks about explicitly setting GOARCH and GOOS, which
is optional. We don't want to have users think it is recommended to set
GOROOT here either, so remove the unnecessary line.

Change-Id: I7dfef09f9a1d003e0253b793d63ea40d5cf1837f
Reviewed-on: https://go-review.googlesource.com/c/161758
Reviewed-by: Andrew Bonventre <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Run-TryBot: Daniel Martí <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
  • Loading branch information
mvdan committed Feb 10, 2019
1 parent ca7c12d commit e1b49ad
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion doc/install-source.html
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,6 @@ <h2 id="environment">Optional environment variables</h2>
</p>

<pre>
export GOROOT=$HOME/go1.X
export GOARCH=amd64
export GOOS=linux
</pre>
Expand Down
5 changes: 0 additions & 5 deletions doc/install.html
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,6 @@ <h4 id="windows_zip">Zip archive</h4>
<a href="/dl/">Download the zip file</a> and extract it into the directory of your choice (we suggest <code>c:\Go</code>).
</p>

<p>
If you chose a directory other than <code>c:\Go</code>,
you must set the <code>GOROOT</code> environment variable to your chosen path.
</p>

<p>
Add the <code>bin</code> subdirectory of your Go root (for example, <code>c:\Go\bin</code>) to your <code>PATH</code> environment variable.
</p>
Expand Down

0 comments on commit e1b49ad

Please sign in to comment.