Skip to content

Commit

Permalink
Date and time need to be before version (protocolbuffers#5777)
Browse files Browse the repository at this point in the history
  • Loading branch information
TeBoring authored Feb 25, 2019
1 parent 580e189 commit 5d8cd3b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions php/ext/google/protobuf/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
<email>[email protected]</email>
<active>yes</active>
</lead>
<date>2019-02-22</date>
<time>11:31:21</time>
<version>
<release>3.7.0RC3</release>
<api>3.7.0</api>
Expand All @@ -18,8 +20,6 @@
<release>beta</release>
<api>beta</api>
</stability>
<date>2019-02-22</date>
<time>11:31:21</time>
<license uri="https://opensource.org/licenses/BSD-3-Clause">3-Clause BSD License</license>
<notes>GA release.</notes>
<contents>
Expand Down
6 changes: 3 additions & 3 deletions update_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,16 +213,16 @@ def CreateNode(tagname, indent, children):
return elem

root = document.documentElement
now = datetime.datetime.now()
ReplaceText(Find(root, 'date'), now.strftime('%Y-%m-%d'))
ReplaceText(Find(root, 'time'), now.strftime('%H:%M:%S'))
version = Find(root, 'version')
ReplaceText(Find(version, 'release'), GetFullVersion(rc_suffix = 'RC'))
ReplaceText(Find(version, 'api'), NEW_VERSION)
stability = Find(root, 'stability')
ReplaceText(Find(stability, 'release'),
'stable' if RC_VERSION == 0 else 'beta')
ReplaceText(Find(stability, 'api'), 'stable' if RC_VERSION == 0 else 'beta')
now = datetime.datetime.now()
ReplaceText(Find(root, 'date'), now.strftime('%Y-%m-%d'))
ReplaceText(Find(root, 'time'), now.strftime('%H:%M:%S'))
changelog = Find(root, 'changelog')
for old_version in changelog.getElementsByTagName('version'):
if Find(old_version, 'release').firstChild.nodeValue == NEW_VERSION:
Expand Down

0 comments on commit 5d8cd3b

Please sign in to comment.