-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: update version of screed to >= 1.1,<2 #2415
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #2415 +/- ##
==========================================
+ Coverage 84.81% 92.58% +7.76%
==========================================
Files 133 104 -29
Lines 14819 12025 -2794
Branches 2513 2513
==========================================
- Hits 12569 11133 -1436
+ Misses 1948 590 -1358
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For nix is likely not finding the new screed version due to Lines 30 to 32 in 1c8b165
I have NixOS/nixpkgs#205878 open to add screed to nixpkgs, extracted from https://github.com/sourmash-bio/sourmash/pull/2393/files#diff-206b9ce276ab5971a2489d75eb1b12999d4bf3843b7988cbe8d687cfde61dea0R63 where Nix is using only deps from nixpkgs (and so no need to check PyPI updates), but both are not merged yet 🙃 |
118bab3
to
02e41c8
Compare
|
|
|
…update/screed_version
Mostly for unblocking #2415, with this update `nixpkgs` has screed `1.1.2`
Fixes #2394.
The main update in screed from 1.0.5 to 1.1 was dib-lab/screed#90, which closes an unclosed file handle.
This PR also puts an upper bound on the screed version.