Skip to content

Commit

Permalink
Migrate st_magic to playwright (streamlit#8316)
Browse files Browse the repository at this point in the history
<!--
⚠️ BEFORE CONTRIBUTING PLEASE READ OUR CONTRIBUTING GUIDELINES!
https://github.com/streamlit/streamlit/wiki/Contributing
-->

## Describe your changes
- title
## GitHub Issue Link (if applicable)

## Testing Plan

- Explanation of why no additional tests are needed
- Unit Tests (JS and/or Python)
- E2E Tests
- Any manual testing needed?

---

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.

---------

Co-authored-by: willhuang1997 <[email protected]>
  • Loading branch information
sfc-gh-wihuang and willhuang1997 authored Mar 19, 2024
1 parent ef2851f commit 1fa90d7
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 49 deletions.
49 changes: 0 additions & 49 deletions e2e/specs/st_magic.spec.js

This file was deleted.

File renamed without changes.
36 changes: 36 additions & 0 deletions e2e_playwright/st_magic_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Copyright (c) Streamlit Inc. (2018-2022) Snowflake Inc. (2022-2024)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from playwright.sync_api import Page, expect


def test_magic_shows_correct_text(app: Page):
expected = [
"no block",
"This should be printed",
"IF",
"ELIF",
"ELSE",
"FOR",
"WHILE",
"WITH",
"TRY",
"EXCEPT",
"FINALLY",
"FUNCTION",
"ASYNC FUNCTION",
"ASYNC FOR",
"ASYNC WITH",
]
for i in range(len(expected)):
expect(app.get_by_test_id("stMarkdown").nth(i)).to_have_text(expected[i])

0 comments on commit 1fa90d7

Please sign in to comment.