Clean-up a couple of aspects in playwright e2e tests (streamlit#8018)

* Add some cleanups * Unifies rerun method * Update snapshots
souvikmaji · Jan 25, 2024 · 37f9e36 · 37f9e36
1 parent 3e69cd4
commit 37f9e36
Show file tree

Hide file tree

Showing 60 changed files with 112 additions and 294 deletions.
diff --git a/e2e/specs/modals.spec.js b/e2e/specs/modals.spec.js
diff --git a/...vega_lite_chart5[dark_theme-chromium].png → ...ega_lite_chart-5[dark_theme-chromium].png b/...vega_lite_chart5[dark_theme-chromium].png → ...ega_lite_chart-5[dark_theme-chromium].png
diff --git a/..._vega_lite_chart5[dark_theme-firefox].png → ...vega_lite_chart-5[dark_theme-firefox].png b/..._vega_lite_chart5[dark_theme-firefox].png → ...vega_lite_chart-5[dark_theme-firefox].png
diff --git a/...w_vega_lite_chart5[dark_theme-webkit].png → ..._vega_lite_chart-5[dark_theme-webkit].png b/...w_vega_lite_chart5[dark_theme-webkit].png → ..._vega_lite_chart-5[dark_theme-webkit].png
diff --git a/...ega_lite_chart5[light_theme-chromium].png → ...ga_lite_chart-5[light_theme-chromium].png b/...ega_lite_chart5[light_theme-chromium].png → ...ga_lite_chart-5[light_theme-chromium].png
diff --git a/...vega_lite_chart5[light_theme-firefox].png → ...ega_lite_chart-5[light_theme-firefox].png b/...vega_lite_chart5[light_theme-firefox].png → ...ega_lite_chart-5[light_theme-firefox].png
diff --git a/..._vega_lite_chart5[light_theme-webkit].png → ...vega_lite_chart-5[light_theme-webkit].png b/..._vega_lite_chart5[light_theme-webkit].png → ...vega_lite_chart-5[light_theme-webkit].png
diff --git a/...vega_lite_chart6[dark_theme-chromium].png → ...ega_lite_chart-6[dark_theme-chromium].png b/...vega_lite_chart6[dark_theme-chromium].png → ...ega_lite_chart-6[dark_theme-chromium].png
diff --git a/..._vega_lite_chart6[dark_theme-firefox].png → ...vega_lite_chart-6[dark_theme-firefox].png b/..._vega_lite_chart6[dark_theme-firefox].png → ...vega_lite_chart-6[dark_theme-firefox].png
diff --git a/...w_vega_lite_chart6[dark_theme-webkit].png → ..._vega_lite_chart-6[dark_theme-webkit].png b/...w_vega_lite_chart6[dark_theme-webkit].png → ..._vega_lite_chart-6[dark_theme-webkit].png
diff --git a/...ega_lite_chart6[light_theme-chromium].png → ...ga_lite_chart-6[light_theme-chromium].png b/...ega_lite_chart6[light_theme-chromium].png → ...ga_lite_chart-6[light_theme-chromium].png
diff --git a/...vega_lite_chart6[light_theme-firefox].png → ...ega_lite_chart-6[light_theme-firefox].png b/...vega_lite_chart6[light_theme-firefox].png → ...ega_lite_chart-6[light_theme-firefox].png
diff --git a/..._vega_lite_chart6[light_theme-webkit].png → ...vega_lite_chart-6[light_theme-webkit].png b/..._vega_lite_chart6[light_theme-webkit].png → ...vega_lite_chart-6[light_theme-webkit].png
diff --git a/...vega_lite_chart7[dark_theme-chromium].png → ...ega_lite_chart-7[dark_theme-chromium].png b/...vega_lite_chart7[dark_theme-chromium].png → ...ega_lite_chart-7[dark_theme-chromium].png
diff --git a/..._vega_lite_chart7[dark_theme-firefox].png → ...vega_lite_chart-7[dark_theme-firefox].png b/..._vega_lite_chart7[dark_theme-firefox].png → ...vega_lite_chart-7[dark_theme-firefox].png
diff --git a/...w_vega_lite_chart7[dark_theme-webkit].png → ..._vega_lite_chart-7[dark_theme-webkit].png b/...w_vega_lite_chart7[dark_theme-webkit].png → ..._vega_lite_chart-7[dark_theme-webkit].png
diff --git a/...ega_lite_chart7[light_theme-chromium].png → ...ga_lite_chart-7[light_theme-chromium].png b/...ega_lite_chart7[light_theme-chromium].png → ...ga_lite_chart-7[light_theme-chromium].png
diff --git a/...vega_lite_chart7[light_theme-firefox].png → ...ega_lite_chart-7[light_theme-firefox].png b/...vega_lite_chart7[light_theme-firefox].png → ...ega_lite_chart-7[light_theme-firefox].png
diff --git a/..._vega_lite_chart7[light_theme-webkit].png → ...vega_lite_chart-7[light_theme-webkit].png b/..._vega_lite_chart7[light_theme-webkit].png → ...vega_lite_chart-7[light_theme-webkit].png
diff --git a/...vega_lite_chart8[dark_theme-chromium].png → ...ega_lite_chart-8[dark_theme-chromium].png b/...vega_lite_chart8[dark_theme-chromium].png → ...ega_lite_chart-8[dark_theme-chromium].png
diff --git a/..._vega_lite_chart8[dark_theme-firefox].png → ...vega_lite_chart-8[dark_theme-firefox].png b/..._vega_lite_chart8[dark_theme-firefox].png → ...vega_lite_chart-8[dark_theme-firefox].png
diff --git a/...w_vega_lite_chart8[dark_theme-webkit].png → ..._vega_lite_chart-8[dark_theme-webkit].png b/...w_vega_lite_chart8[dark_theme-webkit].png → ..._vega_lite_chart-8[dark_theme-webkit].png
diff --git a/...ega_lite_chart8[light_theme-chromium].png → ...ga_lite_chart-8[light_theme-chromium].png b/...ega_lite_chart8[light_theme-chromium].png → ...ga_lite_chart-8[light_theme-chromium].png
diff --git a/...vega_lite_chart8[light_theme-firefox].png → ...ega_lite_chart-8[light_theme-firefox].png b/...vega_lite_chart8[light_theme-firefox].png → ...ega_lite_chart-8[light_theme-firefox].png
diff --git a/..._vega_lite_chart8[light_theme-webkit].png → ...vega_lite_chart-8[light_theme-webkit].png b/..._vega_lite_chart8[light_theme-webkit].png → ...vega_lite_chart-8[light_theme-webkit].png
diff --git a/..._default_theming[dark_theme-chromium].png → ...-default_theming[dark_theme-chromium].png b/..._default_theming[dark_theme-chromium].png → ...-default_theming[dark_theme-chromium].png
diff --git a/...t_default_theming[dark_theme-firefox].png → ...t-default_theming[dark_theme-firefox].png b/...t_default_theming[dark_theme-firefox].png → ...t-default_theming[dark_theme-firefox].png
diff --git a/...rt_default_theming[dark_theme-webkit].png → ...rt-default_theming[dark_theme-webkit].png b/...rt_default_theming[dark_theme-webkit].png → ...rt-default_theming[dark_theme-webkit].png
diff --git a/...default_theming[light_theme-chromium].png → ...default_theming[light_theme-chromium].png b/...default_theming[light_theme-chromium].png → ...default_theming[light_theme-chromium].png
diff --git a/..._default_theming[light_theme-firefox].png → ...-default_theming[light_theme-firefox].png b/..._default_theming[light_theme-firefox].png → ...-default_theming[light_theme-firefox].png
diff --git a/...t_default_theming[light_theme-webkit].png → ...t-default_theming[light_theme-webkit].png b/...t_default_theming[light_theme-webkit].png → ...t-default_theming[light_theme-webkit].png
diff --git a/..._vega_lite_chart[dark_theme-chromium].png → ...hart-interactive[dark_theme-chromium].png b/..._vega_lite_chart[dark_theme-chromium].png → ...hart-interactive[dark_theme-chromium].png
diff --git a/...w_vega_lite_chart[dark_theme-firefox].png → ...chart-interactive[dark_theme-firefox].png b/...w_vega_lite_chart[dark_theme-firefox].png → ...chart-interactive[dark_theme-firefox].png
diff --git a/...ow_vega_lite_chart[dark_theme-webkit].png → ..._chart-interactive[dark_theme-webkit].png b/...ow_vega_lite_chart[dark_theme-webkit].png → ..._chart-interactive[dark_theme-webkit].png
diff --git a/...vega_lite_chart[light_theme-chromium].png → ...art-interactive[light_theme-chromium].png b/...vega_lite_chart[light_theme-chromium].png → ...art-interactive[light_theme-chromium].png
diff --git a/..._vega_lite_chart[light_theme-firefox].png → ...hart-interactive[light_theme-firefox].png b/..._vega_lite_chart[light_theme-firefox].png → ...hart-interactive[light_theme-firefox].png
diff --git a/...w_vega_lite_chart[light_theme-webkit].png → ...chart-interactive[light_theme-webkit].png b/...w_vega_lite_chart[light_theme-webkit].png → ...chart-interactive[light_theme-webkit].png
diff --git a/...chart_theming_10[dark_theme-chromium].png → ...chart-theming_10[dark_theme-chromium].png b/...chart_theming_10[dark_theme-chromium].png → ...chart-theming_10[dark_theme-chromium].png
diff --git a/..._chart_theming_10[dark_theme-firefox].png → ..._chart-theming_10[dark_theme-firefox].png b/..._chart_theming_10[dark_theme-firefox].png → ..._chart-theming_10[dark_theme-firefox].png
diff --git a/...e_chart_theming_10[dark_theme-webkit].png → ...e_chart-theming_10[dark_theme-webkit].png b/...e_chart_theming_10[dark_theme-webkit].png → ...e_chart-theming_10[dark_theme-webkit].png
diff --git a/...hart_theming_10[light_theme-chromium].png → ...hart-theming_10[light_theme-chromium].png b/...hart_theming_10[light_theme-chromium].png → ...hart-theming_10[light_theme-chromium].png
diff --git a/...chart_theming_10[light_theme-firefox].png → ...chart-theming_10[light_theme-firefox].png b/...chart_theming_10[light_theme-firefox].png → ...chart-theming_10[light_theme-firefox].png
diff --git a/..._chart_theming_10[light_theme-webkit].png → ..._chart-theming_10[light_theme-webkit].png b/..._chart_theming_10[light_theme-webkit].png → ..._chart-theming_10[light_theme-webkit].png
diff --git a/..._chart_theming_9[dark_theme-chromium].png → ..._chart-theming_9[dark_theme-chromium].png b/..._chart_theming_9[dark_theme-chromium].png → ..._chart-theming_9[dark_theme-chromium].png
diff --git a/...e_chart_theming_9[dark_theme-firefox].png → ...e_chart-theming_9[dark_theme-firefox].png b/...e_chart_theming_9[dark_theme-firefox].png → ...e_chart-theming_9[dark_theme-firefox].png
diff --git a/...te_chart_theming_9[dark_theme-webkit].png → ...te_chart-theming_9[dark_theme-webkit].png b/...te_chart_theming_9[dark_theme-webkit].png → ...te_chart-theming_9[dark_theme-webkit].png
diff --git a/...chart_theming_9[light_theme-chromium].png → ...chart-theming_9[light_theme-chromium].png b/...chart_theming_9[light_theme-chromium].png → ...chart-theming_9[light_theme-chromium].png
diff --git a/..._chart_theming_9[light_theme-firefox].png → ..._chart-theming_9[light_theme-firefox].png b/..._chart_theming_9[light_theme-firefox].png → ..._chart-theming_9[light_theme-firefox].png
diff --git a/...e_chart_theming_9[light_theme-webkit].png → ...e_chart-theming_9[light_theme-webkit].png b/...e_chart_theming_9[light_theme-webkit].png → ...e_chart-theming_9[light_theme-webkit].png
diff --git a/..._supplied_colors[dark_theme-chromium].png → ..._supplied_colors[dark_theme-chromium].png b/..._supplied_colors[dark_theme-chromium].png → ..._supplied_colors[dark_theme-chromium].png
diff --git a/...r_supplied_colors[dark_theme-firefox].png → ...r_supplied_colors[dark_theme-firefox].png b/...r_supplied_colors[dark_theme-firefox].png → ...r_supplied_colors[dark_theme-firefox].png
diff --git a/...er_supplied_colors[dark_theme-webkit].png → ...er_supplied_colors[dark_theme-webkit].png b/...er_supplied_colors[dark_theme-webkit].png → ...er_supplied_colors[dark_theme-webkit].png
diff --git a/...supplied_colors[light_theme-chromium].png → ...supplied_colors[light_theme-chromium].png b/...supplied_colors[light_theme-chromium].png → ...supplied_colors[light_theme-chromium].png
diff --git a/..._supplied_colors[light_theme-firefox].png → ..._supplied_colors[light_theme-firefox].png b/..._supplied_colors[light_theme-firefox].png → ..._supplied_colors[light_theme-firefox].png
diff --git a/...r_supplied_colors[light_theme-webkit].png → ...r_supplied_colors[light_theme-webkit].png b/...r_supplied_colors[light_theme-webkit].png → ...r_supplied_colors[light_theme-webkit].png
diff --git a/e2e_playwright/conftest.py b/e2e_playwright/conftest.py
@@ -542,8 +542,3 @@ def compare(
 
     if test_failure_messages:
         pytest.fail("Missing snapshots: \n" + "\n".join(test_failure_messages))
-
-
-def rerun(page: Page):
-    page.keyboard.press("r")
-    wait_for_app_run(page)
diff --git a/e2e_playwright/forward_msg_cache_test.py b/e2e_playwright/forward_msg_cache_test.py
@@ -14,12 +14,12 @@
 
 from playwright.sync_api import Page, expect
 
-from e2e_playwright.conftest import rerun
+from e2e_playwright.conftest import rerun_app
 
 
 def test_forward_msg_cache_receives_msg(app: Page):
     app.evaluate("window.streamlitDebug.clearForwardMsgCache()")
-    rerun(app)
+    rerun_app(app)
     expect(app.get_by_role("dialog")).not_to_be_visible()
 
     app.expect_request("**/_stcore/message/")
diff --git a/e2e_playwright/st_arrow_vega_lite_chart_test.py b/e2e_playwright/st_arrow_vega_lite_chart_test.py
diff --git a/e2e_playwright/st_arrow_vega_lite_chart.py → e2e_playwright/st_vega_lite_chart.py b/e2e_playwright/st_arrow_vega_lite_chart.py → e2e_playwright/st_vega_lite_chart.py