[DNM] Backport of p2p-improvements (testing) #5349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions are test builds that are not intended for use on the mainnet. This PR makes it possible to enforce that by making any builds from git tags that contain `nomain` substring refuse to run on the mainnet.
Allow multiple values
Suspend routing discovery when there's enough peers Use DHT to find ping peers
Make advertising for peer discovery optional Stop routing discovery after lowPeers Refactor Improve test
- Enable the developers to manually request a creation of a valid and public dev docker image
-That can be helpful at the testnet or in other tests, avoiding the tag creation.
## Motivation
- Enable the developers to manually request a creation of a valid and public dev docker image
-That can be helpful at the testnet or in other tests, avoiding the tag creation.
## Changes
New GH Action file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.2 #5349 +/- ##
======================================
Coverage ? 77.3%
======================================
Files ? 261
Lines ? 31191
Branches ? 0
======================================
Hits ? 24141
Misses ? 5529
Partials ? 1521 ☔ View full report in Codecov by Sentry. |
|
Closing in favor of #5383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #5329 to the
v1.2branch