fixex #352, Http Digest Auth typo

spacemonkey · Apr 22, 2011 · c4cc363 · c4cc363
1 parent c2356b2
commit c4cc363
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/libraries/lithium/security/auth/adapter/Http.php b/libraries/lithium/security/auth/adapter/Http.php
@@ -8,8 +8,6 @@
 
 namespace lithium\security\auth\adapter;
 
-use lithium\core\Libraries;
-
 /**
  * The `Http` adapter provides basic and digest authentication based on the HTTP protocol.
  * By default, the adapter uses Http Digest based authentication.
@@ -133,7 +131,7 @@ protected function _digest($request) {
 			$nonce = uniqid();
 			$opaque = md5($realm);
 
-			$message = "WWW-Authenticate: Digest realm=\"{$realm}\" qop=\"auth\",";
+			$message = "WWW-Authenticate: Digest realm=\"{$realm}\",qop=\"auth\",";
 			$message .= "nonce=\"{$nonce}\",opaque=\"{$opaque}\"";
 			$this->_writeHeader($message);
 			return;

diff --git a/libraries/lithium/tests/cases/security/auth/adapter/HttpTest.php b/libraries/lithium/tests/cases/security/auth/adapter/HttpTest.php
@@ -48,7 +48,8 @@ public function testCheckDigestIsFalse() {
 		$this->assertFalse($result);
 
 		$this->assertPattern('/Digest/', $http->headers[0]);
-		$this->assertPattern('/qop="auth"/', $http->headers[0]);
+		$this->assertPattern('/realm="app",/', $http->headers[0]);
+		$this->assertPattern('/qop="auth",/', $http->headers[0]);
 		$this->assertPattern('/nonce=/', $http->headers[0]);
 	}