Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 encode credential id #9

Merged
merged 1 commit into from
Feb 14, 2025
Merged

utf8 encode credential id #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
utf8 encode credential id
  • Loading branch information
@thijsdewitt
thijsdewitt committed Feb 12, 2025
commit 73e7e998b1688702c96fd5179068d0a59dc981e0
2 changes: 1 addition & 1 deletion src/Actions/FindPasskeyToAuthenticateAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ protected function findPasskey(PublicKeyCredential $publicKeyCredential): ?Passk
{
$passkeyModel = Config::getPassKeyModel();

return $passkeyModel::firstWhere('credential_id', $publicKeyCredential->rawId);
return $passkeyModel::firstWhere('credential_id', utf8_encode($publicKeyCredential->rawId));
}

protected function determinePublicKeyCredentialSource(
Expand Down
2 changes: 1 addition & 1 deletion src/Models/Passkey.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function data(): Attribute
PublicKeyCredentialSource::class
),
set: fn (PublicKeyCredentialSource $value) => [
'credential_id' => $value->publicKeyCredentialId,
'credential_id' => utf8_encode($value->publicKeyCredentialId),
'data' => $serializer->toJson($value),
],
);
Expand Down