cumulate errors in bulk indexer #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a fix for the shutdown races. |
kytrinyx
added a commit
that referenced
this pull request
Mar 23, 2015
cumulate errors in bulk indexer
|
I looked at the elastic package, and it's pretty complex. All I really want is a client that does basic connection pooling and bulk indexing. We don't need the almighty DSL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk indexer is still racy, as seen by the
TestBulkErrorsrandom failures. This is not caused by this change, this was already the case (the TestBulkErrors test was actually commented out in the original version).I will try to fix the biggest issue - the data race that causes some index requests to not be executed before the indexer stops - but the code is brittle and overly complex, I would still recommend using a different package or a major rewrite of this.