Skip to content

Commit

Permalink
Spelling (actions#72)
Browse files Browse the repository at this point in the history
* spelling: check in

* spelling: compatibility

* spelling: definitely

* spelling: does not

* spelling: maintaining

* spelling: nonexistent

* spelling: precede

* spelling: response

* spelling: was not
  • Loading branch information
jsoref authored and Danny McCormick committed Aug 21, 2019
1 parent 7d60599 commit ad054c8
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions docs/action-versioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ steps:
Binding to the immutable sha1 of a released version is the safest for stability and security.
Binding to a specific major version allows for receiving critical fixes and security patches while still mainting compatibility and the assurance your workflow should still work.
Binding to a specific major version allows for receiving critical fixes and security patches while still maintaining compatibility and the assurance your workflow should still work.
Binding to master is convenient but if a new major version is released which breaks compatilibility, your workflow could break.
Binding to master is convenient but if a new major version is released which breaks compatibility, your workflow could break.
# Recommendations
Expand Down
2 changes: 1 addition & 1 deletion docs/javascript-action.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ $ git checkout -b v1-release

> NOTE: We will provide tooling and an action to automate this soon.
Checkin production dependencies:
Check in production dependencies:
1. **Do not ignore node_modules**: Add a `!` in front of the `node_modules` line.
2. **Delete node_modules**: rm -Rf node_modules
3. **Install production dependencies**: npm install --production
Expand Down
2 changes: 1 addition & 1 deletion packages/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ try {
core.debug('Inside try block');

if (!myInput) {
core.warning('myInput wasnt set');
core.warning('myInput was not set');
}

// Do stuff
Expand Down
6 changes: 3 additions & 3 deletions packages/core/__tests__/lib.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const testEnvVars = {
// Set inputs
INPUT_MY_INPUT: 'val',
INPUT_MISSING: '',
'INPUT_SPECIAL_CHARS_\'\t"\\': '\'\t"\\ repsonse '
'INPUT_SPECIAL_CHARS_\'\t"\\': '\'\t"\\ response '
}

describe('@actions/core', () => {
Expand Down Expand Up @@ -101,7 +101,7 @@ describe('@actions/core', () => {
)
})

it('getInput doesnt throw on missing non-required input', () => {
it('getInput does not throw on missing non-required input', () => {
expect(core.getInput('missing', {required: false})).toBe('')
})

Expand All @@ -110,7 +110,7 @@ describe('@actions/core', () => {
})

it('getInput handles special characters', () => {
expect(core.getInput('special chars_\'\t"\\')).toBe('\'\t"\\ repsonse')
expect(core.getInput('special chars_\'\t"\\')).toBe('\'\t"\\ response')
})

it('setOutput produces the correct command', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface CommandProperties {
*
* Examples:
* ##[warning]This is the user warning message
* ##[set-secret name=mypassword]definatelyNotAPassword!
* ##[set-secret name=mypassword]definitelyNotAPassword!
*/
export function issueCommand(
command: string,
Expand Down
2 changes: 1 addition & 1 deletion packages/exec/src/toolrunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ export class ToolRunner extends events.EventEmitter {
// command line from libuv quoting rules would look like:
// foo.exe "myarg:\"my val\""
//
// 3) double-up slashes that preceed a quote,
// 3) double-up slashes that precede a quote,
// e.g. hello \world => "hello \world"
// hello\"world => "hello\\""world"
// hello\\"world => "hello\\\\""world"
Expand Down
6 changes: 3 additions & 3 deletions packages/io/__tests__/io.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ describe('cp', () => {
})

it('copies directory into non-existing destination with -r', async () => {
const root: string = path.join(getTestTemp(), 'cp_with_-r_nonexisting_dest')
const root: string = path.join(getTestTemp(), 'cp_with_-r_nonexistent_dest')
const sourceFolder: string = path.join(root, 'cp_source')
const sourceFile: string = path.join(sourceFolder, 'cp_source_file')

Expand Down Expand Up @@ -245,7 +245,7 @@ describe('mv', () => {
it('moves directory into non-existing destination', async () => {
const root: string = path.join(
getTestTemp(),
' mv_with_-r_nonexisting_dest'
' mv_with_-r_nonexistent_dest'
)
const sourceFolder: string = path.join(root, ' mv_source')
const sourceFile: string = path.join(sourceFolder, ' mv_source_file')
Expand Down Expand Up @@ -321,7 +321,7 @@ describe('rmRF', () => {
await assertNotExists(testPath)
})

it('removes folder that doesnt exist with rmRF', async () => {
it('removes folder that does not exist with rmRF', async () => {
const testPath = path.join(getTestTemp(), 'testFolder')
await assertNotExists(testPath)

Expand Down

0 comments on commit ad054c8

Please sign in to comment.