Skip to content

Commit

Permalink
Removing some same css that coming from modal.css (adobecom#459)
Browse files Browse the repository at this point in the history
* Removing some same css that coming from modal.css

* Removing all .region-selector & .region-selector-text from footer.css

* Bring the region-selector css back those under footer.

* same.

* Trying to fix unit test.

---------

Co-authored-by: Ryan Clayton <[email protected]>
  • Loading branch information
seanchoi-dev and rgclayton authored Feb 16, 2023
1 parent 0a21814 commit 08c6ac1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
16 changes: 0 additions & 16 deletions libs/blocks/footer/footer.css
Original file line number Diff line number Diff line change
Expand Up @@ -333,18 +333,6 @@ footer .footer-region-button.inline-dialog-active svg.icon-chevron-down {
margin-left: 6px;
}

.region-selector-text {
padding: 0 32px;
}

.region-selector {
padding: 0 32px 32px;
}

.region-selector .content {
column-count: 1;
}

@media (min-width: 900px) {
footer {
padding: 40px 0 24px;
Expand Down Expand Up @@ -389,10 +377,6 @@ footer .footer-region-button.inline-dialog-active svg.icon-chevron-down {
margin-bottom: 0;
}

.region-selector .content {
column-count: 3;
}

.footer-privacy-copyright::after {
content: '/';
margin-left: 6px;
Expand Down
1 change: 0 additions & 1 deletion test/blocks/modals/modals.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ describe('Modals', () => {
window.location.hash = '#milo';
await waitForElement('#milo');
expect(document.getElementById('milo')).to.exist;
await sendKeys({ press: 'Tab' });
await delay(100);
expect(document.activeElement.getAttribute('id')).to.equal('milo-button-1');
await sendKeys({ press: 'Tab' });
Expand Down

0 comments on commit 08c6ac1

Please sign in to comment.