This repository has been archived by the owner on Aug 7, 2020. It is now read-only.
Must merge this PR in to run the audit command correctly #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran correctly from console without any errors:
|
|
|
Has QA approval
emmahsax
added a commit
that referenced
this pull request
Dec 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Impact
Fix bug where the auditor will break if
instance.nameis nil, and a bug where the auditor will error if no regex patterns are passed in.Deploy Plan
Rollback Plan
git revert -m 1 MERGE_SHAand perform another deploy.URLs
QA Plan
The two errors I've seen here are one on line 30 of
lib/sport_ngin_aws_auditor/scripts/audit.rb(undefined method 'each' for nil) and one on line 61 oflib/sport_ngin_aws_auditor/instance_helper.rb(no implicit conversion of nil into string)