This repository has been archived by the owner on Aug 7, 2020. It is now read-only.
Define availability zone as attribute for RDS object to avoid errors #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfleene
approved these changes
Feb 23, 2017
QA:The command now works in terminal: And on Slack: |
|
|
Has QA approval
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Impact
Like in
cache_instance.rbandec2_instance.rb, we need to define what.availability_zoneshould be for each object. The documentation (linked below) says what each RDS instance has, so we need to define those in ours so that when we call it on line 100 ofaudit.rb, the objects are ready.Deploy Plan
Rollback Plan
git revert -m 1 MERGE_SHAand perform another deploy.URLs
http://docs.aws.amazon.com/sdkforruby/api/Aws/RDS/Client.html
QA Plan