Fix broken docs caused by incorrect feature-scroll
usage in Antora
#3262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of issues with the
feature-scroll
attribute in the Antora docs:endif::[]
for the Offset-based Window table row is placed incorrectly:spring-data-commons/src/main/antora/modules/ROOT/pages/repositories/query-methods-details.adoc
Lines 455 to 464 in f4e9581
This causes the table to break when
feature-scroll
is not set::feature-scroll: true
in index.adoc has no effect because attributes set on one page are not visible to other pages. Additionally, setting the attribute value totrue
is redundant —ifdef
blocks are evaluated based on whether the attribute is defined, regardless of its value (source).As a result, Scroll API-related content is always hidden in the documentation.
This PR fixes the above by explicitly defining the
:feature-scroll:
attribute in the two pages where it's used: