Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JDK 22 on github actions as AGP requires java 17 and above #22

Closed
wants to merge 5 commits into from

Conversation

eyedol
Copy link
Contributor

@eyedol eyedol commented Dec 21, 2024

Fixes CI issue where AGP requires Java 17 and above

@eyedol
Copy link
Contributor Author

eyedol commented Dec 23, 2024

@sproctor could you merge this if all is good? It fixes an issue with a missing actual implementation for VerticalScrollbar and HorizontalScrollbar implementations for the js target.

@sproctor
Copy link
Owner

I don't want to use a non-LTS JDK. I changed it to 21. I had removed the JS target from the demo stuff since there's no JS demo. I guess I'll eventually add one, so I merged the JVM and JS implementations for the scrollbar. I've diverged pretty far from this, so I'm going to close it. If there's stuff in it that you think should be merged, create a new PR.

@sproctor sproctor closed this Dec 28, 2024
@eyedol
Copy link
Contributor Author

eyedol commented Dec 28, 2024

I don't want to use a non-LTS JDK. I changed it to 21. I had removed the JS target from the demo stuff since there's no JS demo. I guess I'll eventually add one, so I merged the JVM and JS implementations for the scrollbar. I've diverged pretty far from this, so I'm going to close it. If there's stuff in it that you think should be merged, create a new PR.

Makes sense. Nah. Nothing in there deserves a merge. Good you closed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants