Merge pull request marcoarment#11 from jgallagher/fix-error-message

Save FMDB errors before calling -rollback. (Nice find.)
sprucehealth · Oct 10, 2013 · e76a121 · e76a121
2 parents afcc702 + ed1f1d1
commit e76a121
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -84,8 +84,10 @@ NSString *dbPath = [documentsPath stringByAppendingPathComponent:@"testDB.sqlite
 
     // My custom failure handling. Yours may vary.
     void (^failedAt)(int statement) = ^(int statement){
+        int lastErrorCode = db.lastErrorCode;
+        NSString *lastErrorMessage = db.lastErrorMessage;
         [db rollback];
-        NSAssert3(0, @"Migration statement %d failed, code %d: %@", statement, db.lastErrorCode, db.lastErrorMessage);
+        NSAssert3(0, @"Migration statement %d failed, code %d: %@", statement, lastErrorCode, lastErrorMessage);
     };
 
     if (*schemaVersion < 1) {

diff --git a/example/FCModelTest Tests/FCModelTest_Tests.m b/example/FCModelTest Tests/FCModelTest_Tests.m
@@ -75,8 +75,10 @@ - (void)openDatabase
         [db beginTransaction];
 
         void (^failedAt)(int statement) = ^(int statement){
+            int lastErrorCode = db.lastErrorCode;
+            NSString *lastErrorMessage = db.lastErrorMessage;
             [db rollback];
-            NSAssert3(0, @"Migration statement %d failed, code %d: %@", statement, db.lastErrorCode, db.lastErrorMessage);
+            NSAssert3(0, @"Migration statement %d failed, code %d: %@", statement, lastErrorCode, lastErrorMessage);
         };
 
         if (*schemaVersion < 1) {

diff --git a/example/FCModelTest/AppDelegate.m b/example/FCModelTest/AppDelegate.m
@@ -28,8 +28,10 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
         [db beginTransaction];
 
         void (^failedAt)(int statement) = ^(int statement){
+            int lastErrorCode = db.lastErrorCode;
+            NSString *lastErrorMessage = db.lastErrorMessage;
             [db rollback];
-            NSAssert3(0, @"Migration statement %d failed, code %d: %@", statement, db.lastErrorCode, db.lastErrorMessage);
+            NSAssert3(0, @"Migration statement %d failed, code %d: %@", statement, lastErrorCode, lastErrorMessage);
         };
 
         if (*schemaVersion < 1) {