Generate Dagger modules for @ContributesBinding with basic configuration #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelWilcox
commented
Feb 12, 2025
| import org.jetbrains.kotlin.name.Name | ||
|
|
||
| @OptIn(ExperimentalTopLevelDeclarationsGenerationApi::class) | ||
| public class BindingModuleData( |
There was a problem hiding this comment.
I kept the structure here mostly in-line with the POC branch until we can discuss concerns/alternatives (related https://github.com/square/anvil/pull/1110/files#r1951710072), and also because I'd like us to get the merging impl + related integration tests in before doing any heavier refactoring.
JoelWilcox
force-pushed
the
joel/contributes-binding-min-generation
branch
from
aa7725d to
f1ff407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal FIR impl that handles generating the associated Dagger module with @ContributesTo and @module annotations, as well as the expected @BINDS method. Support for other configurations like ignoring qualifiers and replacing contributions will come as followup incremental changes.