Skip to content

Commit

Permalink
refactor(forc-pkg): Attempt to simplify build/compile fns by introduc…
Browse files Browse the repository at this point in the history
…ing dedicated types (FuelLabs#4209)

## Description

This introduces the `CompiledPackage` and `CompiledContractDependency`
types in order to more accurately model the inputs and outputs of the
`compile` function.

We also move the `name` and `target` fields from `BuiltPackage` into the
`PackageDescriptor`, construct the descriptor earlier in the build
process, and use the descriptor to consolidate more of the `compile`
function arguments.

I started on refactoring some of the ABI generation related code, but
realised that this might involve a more dedicated effort and opened
FuelLabs#4208.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
  • Loading branch information
mitchmindtree authored Mar 10, 2023
1 parent 318fcde commit 3d5698e
Show file tree
Hide file tree
Showing 4 changed files with 212 additions and 206 deletions.
Loading

0 comments on commit 3d5698e

Please sign in to comment.