Skip to content

Commit

Permalink
Fix typo in least squares solver. Haven't been able to construct exam…
Browse files Browse the repository at this point in the history
…ple where the typo mattered so no test.
  • Loading branch information
andreasnoack committed Apr 14, 2015
1 parent d534b00 commit 7aa65b4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions base/linalg/factorization.jl
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,9 @@ function A_ldiv_B!{T<:BlasFloat}(A::QRPivoted{T}, B::StridedMatrix{T}, rcond::Re
push!(xmax, cmax)
for i = 1:rnk
xmin[i] *= smin
xmax[i] = smax*xmin[i]
xmax[i] *= smax
end
rnk += 1
# if cond(r[1:rnk, 1:rnk])*rcond < 1 break end
end
C, τ = LAPACK.tzrzf!(A.factors[1:rnk,:])
A_ldiv_B!(UpperTriangular(C[1:rnk,1:rnk]),sub(Ac_mul_B!(getq(A),sub(B, 1:mA, 1:nrhs)),1:rnk,1:nrhs))
Expand Down

0 comments on commit 7aa65b4

Please sign in to comment.