forked from onivim/oni2
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf/diagnostics/onivim#2407/trace logging cpu usage (onivim#2629)
More investigation into onivim#2407 - based on the latest logs, like: ``` [TRACE] [ 0.061s] Revery.UI.Render : BEGIN: Render frame [TRACE] [ 0.062s] Revery.UI.Render : -- RENDER: pixelRatio: 1.000000 scaleAndZoom: 2.000000 zoom: 2.000000 canvasScaling: 2.000000 [TRACE] [ 0.062s] Revery.UI.Render : -- RENDER: adjustedWidth: 1920 adjustedHeight: 1181 [TRACE] [ 0.067s] Revery.UI.Render : END: Render frame ``` My hypothesis is that there are some animation timers running that are forcing us to re-render - I've added some additional instrumentation in our trace logging here: revery-ui/revery#1011 That change logs out additional information about the timers that are running: ``` [TRACE] [ 4.921s] Revery.Tick : Tick.pump - starting with 4 active tickers. [TRACE] [ 4.921s] Revery.Tick : Interval - running timer: Store: Run Effects 1 [DEBUG] [ 4.921s] Oni2.Store.StoreThread : Running effect: Batch: vim.input [INFO] [ 4.921s] Oni2.Store.dispatch : dispatch: (Vim (Feature_Vim.ModeChanged <opaque>)) [DEBUG] [ 4.922s] Oni2.Store.dispatch : After: (Vim (Feature_Vim.ModeChanged <opaque>)) [INFO] [ 4.922s] Oni2.Store.dispatch : dispatch: QuickmenuClose [DEBUG] [ 4.923s] Oni2.Store.dispatch : After: QuickmenuClose [INFO] [ 4.923s] Oni2.Store.dispatch : dispatch: (Quit true) [DEBUG] [ 4.924s] Oni2.Store.dispatch : After: (Quit true) [INFO] [ 4.925s] Oni2.Store.dispatch : dispatch: Editor {scope = (EditorScope.Editor 1); msg = ModeChanged {mode = <opaque>; effects = <opaque>}} [DEBUG] [ 4.926s] Oni2.Store.dispatch : After: Editor {scope = (EditorScope.Editor 1); msg = ModeChanged {mode = <opaque>; effects = <opaque>}} [DEBUG] [ 4.926s] Oni2.Store.Vim : handled key: <CR> [DEBUG] [ 4.926s] Oni2.Store.StoreThread : Effect complete: Batch: vim.input [TRACE] [ 4.926s] Revery.Tick : Interval - running timer: Oni2_Editor Apploop 0 [TRACE] [ 4.926s] Revery.Tick : Interval - running timer: StatusBar Notification Expirer 31 [TRACE] [ 4.926s] Revery.Tick : Interval - running timer: Notification Animation 32 [TRACE] [ 4.926s] Revery.Tick : Tick.pump - ending with 4 active tickers. [TRACE] [ 4.926s] Revery.UI.Render : BEGIN: Render frame [TRACE] [ 4.930s] Revery.UI.Render : -- RENDER: pixelRatio: 1.000000 scaleAndZoom: 1.000000 zoom: 1.000000 canvasScaling: 1.000000 [TRACE] [ 4.931s] Revery.UI.Render : -- RENDER: adjustedWidth: 1920 adjustedHeight: 1000 [TRACE] [ 4.939s] Revery.UI.Render : END: Render frame ``` This can help to confirm my hypothesis, and if there is an active timer, we can see if it's a general problem or if there is a specific class of timer that is getting caught in a loop. This will be useful logging to have in any case, but hopefully it can get us to closer to fixing onivim#2407
- Loading branch information
Showing
32 changed files
with
120 additions
and
212 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.