Skip to content

Commit

Permalink
[plugin] list onUri as a supported activation event
Browse files Browse the repository at this point in the history
It should be triggered when a os-wide URI is opened, for cloud case it is not necessary, so stubbing for now. As soon as os-wide opening of URIs is implemented for Electron this event should be fired as well.

Signed-off-by: Anton Kosyakov <[email protected]>
  • Loading branch information
akosyakov committed Sep 4, 2019
1 parent d8bc1c3 commit dbadb83
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/plugin-ext/src/plugin/plugin-context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ export function createAPIFactory(
return decorationsExt.registerDecorationProvider(provider);
},
registerUriHandler(handler: theia.UriHandler): theia.Disposable {
// TODO ?
return new Disposable(() => { });
},
createInputBox(): theia.InputBox {
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-ext/src/plugin/plugin-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ export class PluginManagerExtImpl implements PluginManagerExt, PluginManager {
'onCommand',
'onDebug', 'onDebugInitialConfigurations', 'onDebugResolve', 'onDebugAdapterProtocolTracker',
'workspaceContains',
'onView'
'onView',
'onUri'
]);

private readonly registry = new Map<string, Plugin>();
Expand Down

0 comments on commit dbadb83

Please sign in to comment.