Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ab#929 automatic sae helm chart release #2

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

flonix8
Copy link
Contributor

@flonix8 flonix8 commented Oct 23, 2023

Description

I have added a shell script that builds and releases (i.e. uploads to internal Helm repo) the SAE chart.
Also, I created a Github Actions workflow that uses a build container to run the same script, s.t. local and CI build are as similar as possible.

Motivation and Context

How has this been tested?

I tested it multiple times in different configuration. Seems to work (for now)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@flonix8 flonix8 requested review from witchpou and ztarbug October 23, 2023 16:06
.github/workflows/helm-sae-release.yml Show resolved Hide resolved
CHART_FILE=${FILES[0]}

echo "Uploading chart package..."
cat $CHART_FILE | curl -i --fail-with-body -u $HELM_REPO_USER:$HELM_REPO_PASSWORD --data-binary @- https://helm.internal.starwit-infra.de/api/charts || exit 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich finde cm-push irgendwie lesbarer: https://github.com/chartmuseum/helm-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants