Hyperspace #17
Draft
Hyperspace #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
approved these changes
Feb 27, 2023
.env.local-hyperspace
Outdated
| ## simple-hub, xstate-wallet | ||
| CONSENSUS_APP_ADDRESS = '0xeB1170bf49fac482fA296C98Ac04024e8a2d6519' | ||
|
|
||
| ### NitroAdjudicator and ETHAssetHolder deployed by George Knee, by uploading files to https://remix.ethereum.org/ and using compiler 0.6.10+commit.00c0fcaf, optimization ON. Source code verified on https://goerli.etherscan.io/ . |
There was a problem hiding this comment.
Nit: let's clean up the comments and references to Goerli in this file.
| @@ -41,6 +40,7 @@ async function fund(channelID: string, value: BigNumber): Promise<void> { | |||
| } | |||
|
|
|||
| await lock.acquire(channelID, async () => { | |||
| console.log('SANITYTYUASDAS'); | |||
| @@ -94,7 +93,7 @@ async function createEthAssetHolder() { | |||
| {ETH_ASSET_HOLDER_ADDRESS: process.env.ETH_ASSET_HOLDER_ADDRESS}, | |||
| 'Connected to eth asset holder' | |||
| ); | |||
|
|
|||
| console.log(contract); | |||
Comment on lines
+55
to
+56
| // TODO: re-enable this when we figure out the proper way to do this | ||
| //const ready = currentNetwork === requiredNetwork && initialized; |
There was a problem hiding this comment.
Can you explain a bit more?
There was a problem hiding this comment.
It seems that we're not getting the correct chain id from metamask (at least in firefox). We seem to get back a 0 instead of 3141. Mostly like due to changes to how window.ethereum works.
For now I just disabled the check.
| @@ -516,3 +518,4 @@ export class PaymentChannelClient { | |||
| export const paymentChannelClient = new PaymentChannelClient( | |||
| new ChannelClient(window.channelProvider) | |||
| ); | |||
| paymentChannelClient.initialize(); | |||
There was a problem hiding this comment.
Hmm maybe not. It seemed like the payment channel wasn't getting initialized without this but let me investigate.
✅ Deploy Preview for lucky-chaja-70e2bd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fixes warning about <div> being a descendent of <p>
silences a warning about this event being deprecated
and move from dev to prod dependency
Silence some warnings
patch @statechannels/iframe-channel-provider
update FAQ link
Ethereum to hyperspace (website text)
make prettier happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.