This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
feat(QClipboardProxy): add support for images, html and urls #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
force-pushed
the
feat/clipboard-image-base64
branch
from
4adde95 to
79f391b
Compare
caybro
force-pushed
the
feat/clipboard-image-base64
branch
from
79f391b to
7d3513d
Compare
0x-r4bbit
force-pushed
the
feat/clipboard-image-base64
branch
from
7d3513d to
7621c10
Compare
caybro
force-pushed
the
feat/clipboard-image-base64
branch
from
7621c10 to
984e6a0
Compare
caybro
changed the title
saledjenic
approved these changes
Nov 25, 2022
0x-r4bbit
commented
Nov 25, 2022
| const auto img = image(); | ||
| QByteArray byteArray; | ||
| QBuffer buffer(&byteArray); | ||
| img.save(&buffer, "PNG"); // writes the image in PNG format inside the buffer |
There was a problem hiding this comment.
Can we determine whether we really have a PNG? This could be JPG or WEBP as well
There was a problem hiding this comment.
Here we always save as PNG but we could yeah, TODO :)
There was a problem hiding this comment.
Might be problematic for GIFs... we would effectively kill the animation :/
There was a problem hiding this comment.
FWIW I don't think we support sending GIFs as image messages atm
There was a problem hiding this comment.
I stand corrected. It looks like we do
osmaczko
approved these changes
Nov 25, 2022
|
@caybro did the heavy-lifting here. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: status-im/status-desktop#3395