Update keycard Illustrations #22171
Merged
Update keycard Illustrations #22171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (29)
|
Parveshdhull
force-pushed
the
chore/update-keycard-illustrations
branch
4 times, most recently
from
9372d85 to
7f8e3cc
Compare
Parveshdhull
changed the title
Parveshdhull
requested review from
flexsurfer and
ilmotta
and removed request for
flexsurfer
Parveshdhull
force-pushed
the
chore/update-keycard-illustrations
branch
from
7f8e3cc to
5979dad
Compare
|
Hey @Parveshdhull ! Thanks for your PR! If I am not mistaken PR contains old version of illustration here: Profile-> Keycard-> Manage Keycard -> Backup keycard Impementation vs Design
|
|
Hi @Parveshdhull ! Ready to re-test? |
Hi @mariia-skrypnyk, Yes PR is ready to test. |
|
Hi @Parveshdhull ! Thanks! Test report:
Factory reset 📱✅Keycard has been reset Change PIN 📱✅Ready to change PIN Unblock 📱✅Ready to unblock Keycard Other: 📱✅Preparing Status for you... PR can be merged with OR without text added |
Parveshdhull
force-pushed
the
chore/update-keycard-illustrations
branch
from
5050672 to
1b991b6
Compare
|
Thank you very much @mariia-skrypnyk for testing the PR.
I've added the description text. It's a small change, so the PR doesn't need to be tested again. I will merge it once the builds are complete. Thank you
|
100% of end-end tests have passedPassed tests (14)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletCollectibles:
|
This was referenced Feb 24, 2025
ulisesmac
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22168
Testing Note:
Please test that illustrations exist in all keycard flows and let me know if I missed any.
status: ready