Wrong address opening when attempt to edit a saved one #22185
+50
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data to screen was passed via rf-db and acquired in the screen via sbuscription. But sometimes subscription wasnt calculated yet and returned nil value. That nil value was captured by use-state and never updated after subscription updated.
vkjr
commented
Feb 25, 2025
| {:keys [address name customization-color ens ens?]} | ||
| (rf/sub [:wallet/saved-address]) | ||
| (let [{:keys [address name customization-color ens | ||
| ens? edit?]} (rf/sub [:get-screen-params]) | ||
| [address-label set-address-label] (rn/use-state (or name "")) |
There was a problem hiding this comment.
This was a root of the problem - we were using data from the subscription and locking it inside the state. So if screen opened before the subscription value updated we ended up with wrong data saved in state hook. Solution is to pass the correct data as screen params instead of subs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22044
Summary
Address editing fixed
Uploading Screen Recording 2025-02-25 at 10.10.18.mov…
Platforms
Areas that may be impacted
Functional
Steps to test
status: ready